Hi Biju,
On Thu, Mar 3, 2022 at 10:53 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Subject: Re: [PATCH 2/2] dt-bindings: serial: renesas,sci: Update
> > compatible string for RZ/G2UL SoC
> > On Thu, Mar 3, 2022 at 9:59 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > > Both RZ/G2UL and RZ/Five SoC's have SoC ID starting with R9A07G043.
> > > To distinguish between them update the compatible string to
> > > "renesas,r9a07g043u-sci" for RZ/G2UL SoC.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/serial/renesas,sci.yaml
> > > +++ b/Documentation/devicetree/bindings/serial/renesas,sci.yaml
> > > @@ -17,7 +17,7 @@ properties:
> > > oneOf:
> > > - items:
> > > - enum:
> > > - - renesas,r9a07g043-sci # RZ/G2UL
> > > + - renesas,r9a07g043u-sci # RZ/G2UL
> >
> > Is this really needed? As far as we know, RZ/Five and RZ/G2UL do use the
> > same I/O blocks?
>
> OK, Just thought their DEVID is different and they use RISC-V instead of ARM64.
> I agree it uses identical IP blocks.
>
> May be I can drop this patch, if it is not really needed. Please let me know.
I think it is not needed. We used the same compatible values
("r8a7778") for R-Car M1A (R8A77781, SH-4A + CA9) and M1S (R8A77780,
SH-4A only), too, (probably not by design, as we never supported the
latter under arch/sh/ ;-)
We do need a different top-level compatible value for the RZ/Five SoC,
like we already have for the RZ/G2UL variants:
- description: RZ/G2UL (R9A07G043)
items:
- enum:
- renesas,r9a07g043u11 # RZ/G2UL Type-1
- renesas,r9a07g043u12 # RZ/G2UL Type-2
- const: renesas,r9a07g043
So if we ever have an issue due to a difference, we can handle that
through soc_device_match(), just like for RZ/V2L vs. RZ/G2L.
BTW, I guess RZ/G2UL Type-1 and Type-2 do have the same DEVID, and
only differ in PRR?
Any other opinions?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
