On 2/14/22 19:00, Randy Dunlap wrote: > There is a build error when using a kernel .config file from > 'kernel test robot' for a different build problem: > > hppa64-linux-ld: drivers/tty/serial/8250/8250_gsc.o: in function `.LC3': > (.data.rel.ro+0x18): undefined reference to `iosapic_serial_irq' > > when: > CONFIG_GSC=y > CONFIG_SERIO_GSCPS2=y > CONFIG_SERIAL_8250_GSC=y > CONFIG_PCI is not set > and hence PCI_LBA is not set. > IOSAPIC depends on PCI_LBA, so IOSAPIC is not set/enabled. > > Make the use of iosapic_serial_irq() conditional to fix the build error. > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Cc: Helge Deller <deller@xxxxxx> > Cc: linux-parisc@xxxxxxxxxxxxxxx > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: linux-serial@xxxxxxxxxxxxxxx > Cc: Jiri Slaby <jirislaby@xxxxxxxxxx> > Cc: Johan Hovold <johan@xxxxxxxxxx> > Suggested-by: Helge Deller <deller@xxxxxx> Thank you Randy! Acked-by: Helge Deller <deller@xxxxxx> Since this patch only affects the parisc platform, I've added it to the parisc for-next tree (with a stable tag), unless people want it to go through another subsystem tree... Helge > --- > v2: make the call to iosapic_serial_irq() conditional based on > CONFIG_ settings (thanks, Helge) > > drivers/tty/serial/8250/8250_gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20220211.orig/drivers/tty/serial/8250/8250_gsc.c > +++ linux-next-20220211/drivers/tty/serial/8250/8250_gsc.c > @@ -26,7 +26,7 @@ static int __init serial_init_chip(struc > unsigned long address; > int err; > > -#ifdef CONFIG_64BIT > +#if defined(CONFIG_64BIT) && defined(CONFIG_IOSAPIC) > if (!dev->irq && (dev->id.sversion == 0xad)) > dev->irq = iosapic_serial_irq(dev); > #endif >
