Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@xxxxxxxxx> wrote:
> >
> > From: Yang Guang <yang.guang5@xxxxxxxxxx>
> >
> > coccinelle report:
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> > WARNING: use scnprintf or sprintf
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> 
> sysfs_emit()
> scnprintf()
> sprintf()
> 
> ...
> 
> > CC: David Yang <davidcomponentone@xxxxxxxxx>
> 
> > - Use the CC for patch sender
> 
> This is incorrect. The submitter must have (the last) SoB tag.
> Question was about authorship just to be clear.

Please fix up the subject prefix too ("8059").

Johan



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux