Hi,
On 07. 02. 22, 6:58, Hammer Hsieh wrote:
+static void sunplus_shutdown(struct uart_port *port)
+{
+ unsigned long flags;
+ unsigned int isc;
+
+ spin_lock_irqsave(&port->lock, flags);
+
+ isc = readl(port->membase + SUP_UART_ISC);
+ isc &= ~(SUP_UART_ISC_RXM | SUP_UART_ISC_TXM);
Is this correct? I mean: will the SUP_UART_ISC read contain the control
bits, not only status bits?
+ writel(isc, port->membase + SUP_UART_ISC);
+
+ spin_unlock_irqrestore(&port->lock, flags);
+
+ free_irq(port->irq, port);
I am still waiting for explanation why this is safe with respect to
posted writes.
regards,
--
js
suse labs
