RE: [PATCH 2/3] dt-bindings: serial: renesas,scif: Document RZ/G2UL SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 2/3] dt-bindings: serial: renesas,scif: Document
> RZ/G2UL SoC
> 
> Hi Biju,
> 
> On Sun, Feb 6, 2022 at 7:48 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Add SCIF binding documentation for Renesas RZ/G2UL SoC. SCIF block on
> > RZ/G2UL is identical to one found on the RZ/G2L SoC. No driver changes
> > are required as RZ/G2L compatible string "renesas,scif-r9a07g044" will
> > be used as a fallback.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > @@ -76,8 +76,9 @@ properties:
> >
> >        - items:
> >            - enum:
> > +              - renesas,scif-r9a07g043      # RZ/G2UL
> >                - renesas,scif-r9a07g054      # RZ/V2L
> > -          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for
> RZ/V2L
> > +          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for
> RZ/{G2UL,V2L}
> 
> To avoid having to update this comment over and over again, perhaps the
> "for ..." should be dropped?

Agreed, Will drop "for ..." in next version.

Regards,
Biju

> 
> The rest looks good to me.
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux