Re: [PATCH] serial: core: Keep mctrl register state and cached copy in sync

[Jiri Slaby <jirislaby@xxxxxxxxxx>]

On 02. 01. 22, 18:52, Lukas Wunner wrote:
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -2389,7 +2389,8 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
>   		 * We probably don't need a spinlock around this, but

One line above, it states:
--- keep the DTR setting that is set in uart_set_options()

>   		 */
>   		spin_lock_irqsave(&port->lock, flags);
> -		port->ops->set_mctrl(port, port->mctrl & TIOCM_DTR);
> +		port->mctrl &= TIOCM_DTR;
> +		port->ops->set_mctrl(port, port->mctrl);

So I don't think this is correct -- either the comment is wrong now or 
the code...

thanks,
--
js
suse labs