On Fri, Dec 31, 2021 at 11:27 AM Yu Tu <yu.tu@xxxxxxxxxxx> wrote: [...] > >> -/* Legacy bindings, should be removed when no more used */ > >> -OF_EARLYCON_DECLARE(meson, "amlogic,meson-uart", > >> - meson_serial_early_console_setup); > > This part is still needed as long as above series is not merged yet. > > If we remove this then earlycon will stop working on the 32-bit SoCs > > unless [0] is merged. > > > > All other code below - except the of_device_id entry - can still be > > removed since meson8.dtsi and meson8b.dtsi are using the non-legacy > > clocks already. > > > > Sorry for only noticing this now. > > > I will add it back in the next patch and delete it after your submission > is merged. I have just seen that Greg has already added this patch to the tty-next tree [1] In this case there's nothing to do on your end - I'll simply ask Neil to also queue my 32-bit SoC UART .dts fixes [0] for 5.17 Best regards, Martin [0] https://patchwork.kernel.org/project/linux-amlogic/cover/20211227180026.4068352-1-martin.blumenstingl@xxxxxxxxxxxxxx/ [1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-next&id=ad234e2bac274a43c9fa540bde8cd9f0c627b71f
