Re: [PATCH v5 2/2] serial:sunplus-uart:Add Sunplus SoC UART Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 24, 2021 at 05:21:27PM +0800, hammer hsieh wrote:
> Hi, Greg KH:
> 
> I am still not really understand why you said the driver looks like 8250.
> SP7021 SoC have our own register define.
> That's why we submit a new serial driver.
> 
> Refer to:
> https://sunplus.atlassian.net/wiki/spaces/doc/pages/1873412290/13.+Universal+Asynchronous+Receiver+Transmitter+UART

Odd, ok, I thought this was an 8250-like uart, why did they go and
redesign all of the register values for something as well-known as a
UART?

Anyway, I think you are right, please fix up the other issues and resend
the driver and we will be glad to review it again.

thanks,

greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux