On Tue, Dec 21, 2021 at 03:16:32PM +0800, Yu Tu wrote: > Change request_irq to devm_request_irq and free_irq to devm_free_irq. > It's better to change the code this way. Why? What did this fix up? You still are manually requesting and freeing the irq. What bug did you fix? > > The IRQF_SHARED interrupt flag was added because an interrupt error was > detected when the serial port was opened twice in a row on the project. That is a different change. Make that a different patch. thanks, greg k-h