Hi Shimoda-san, On Tue, Dec 7, 2021 at 2:51 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > From: Geert Uytterhoeven, Sent: Monday, December 6, 2021 9:43 PM > > On Wed, Dec 1, 2021 at 8:33 AM Yoshihiro Shimoda > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > > According to the official website [1], the R-Car V3U SoC is based > > > on the R-Car Gen4 architecture. So, introduce R-Car Gen4 CPG > > > driver. > > > > > > [1] > > > > > https://www.renesas.com/us/en/products/automotive-products/automotive-system-chips-socs/r-car-v3u-best-class-r-car-v > > 3u-asil-d-system-chip-automated-driving > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > > +#define DEF_GEN4_Z(_name, _id, _type, _parent, _div, _offset) \ > > > + DEF_BASE(_name, _id, _type, _parent, .div = _div, .offset = _offset) > > > > Is there any specific reason _type is not fixed to CLK_TYPE_GEN4_Z, > > like before? Perhaps you have a future use-case in mind? > > This is a similar definition with DEF_GEN3_Z. And, there is not Right. And we never finished ZG clock support upstream, due to issues with upstream GPU support. > upstream use-case though, if we support ZG clock, we have to use > _type for ZG like Gen3 BSP. In Gen4, we will support ZG clock > on other SoCs in the future, the _type is not fixed. OK, will keep. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
