On Tue, Nov 16, 2021 at 6:09 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tue, Nov 16, 2021 at 4:01 PM Emil Renner Berthing <kernel@xxxxxxxx> wrote: ... > One general (minor) comment about the patches: please put your own > 'Signed-off-by' > into the last line of the patch description, below all the lines you > took from other people, so > instead of: > > | Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> > | Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > | Acked-by: Rob Herring <robh@xxxxxxxxxx> > > do this: > > | Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > | Acked-by: Rob Herring <robh@xxxxxxxxxx> > | Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> Why? Submitting Patches tells about chronological order and last SoB to be from the submitter. These both are correct. Note the difference between 'last SoB' and 'SoB to be last [line]'. Here is the excerpt: "Notably, the last Signed-off-by: must always be that of the developer submitting the patch." -- With Best Regards, Andy Shevchenko
