On Mon, Nov 15, 2021 at 4:34 AM Ilia Sergachev <silia@xxxxxxx> wrote: Besides what Greg asked for, can you rephrase Subject to something like "serial: liteuart: Fix NULL pointer dereference in ->remove()" > drvdata has to be set in _probe() - otherwise platform_get_drvdata() > causes null pointer dereference BUG in _remove() Don't forget the grammatical period. Code looks good to me, though. -- With Best Regards, Andy Shevchenko