> > This usually happens when switch has no default case and static > > analyzers and even sometimes compilers can’t prove that all possible > > values are covered. > > > > > > One blank line is enough. > > > Many thanks to the following for review of previous versions : > > > > * Pavel Skripkin <paskripkin@xxxxxxxxx> > > * Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > > > > Ditto for each such case. Ok, will take care of this in all my future-patches. > > ... > > > + default: > > + kbs = NULL; > > > + ret = -ENOIOCTLCMD; > > Why is this? How is it supposed to work? If there is no match for a cmd, causing the default-case to be hit, we must return an error ret-code to the client. The -ENOIOCTLCMD error ret-code has been chosen, on the same lines as "vt_do_kdskled" method. Thanks and Regards, Ajay
