Re: [PATCH v3] tty: vt: keyboard: add default switch-case, to handle smatch-warnings in method vt_do_kdgkb_ioctl

[Pavel Skripkin <paskripkin@xxxxxxxxx>]

On 11/7/21 01:03, Ajay Garg wrote:
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index c7fbbcdcc346..b83e7669658d 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -2090,6 +2090,12 @@ int vt_do_kdgkb_ioctl(int cmd, struct kbsentry __user *user_kdgkb, int perm)
>   
>   		ret = 0;
>   		break;
> +	default: {
> +		kbs = NULL;
> +		ret = -ENOIOCTLCMD;
> +
> +		break;
> +	}

Are these brackets needed here? There are no local variables inside 
default case.


just my 2c,

With regards,
Pavel Skripkin