Re: [PATCH] tty: Fix extra "not" in TTY_DRIVER_REAL_RAW description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 27, 2021 at 01:21:24PM +0300, Anssi Hannula wrote:
> TTY_DRIVER_REAL_RAW flag (which is always set for e.g. serial ports)
> documentation says that driver must always set special character
> handling flags in certain conditions.
> 
> However, as the following sentence makes clear, what is actually
> intended is the opposite.
> 
> Fix that by removing the unintended double negation.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@xxxxxxxxxx>
> ---

Acked-by: Johan Hovold <johan@xxxxxxxxxx>

> This one seems to have been there since 1994.
> 
>  include/linux/tty_driver.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
> index c20431d8def8..5bec04481c60 100644
> --- a/include/linux/tty_driver.h
> +++ b/include/linux/tty_driver.h
> @@ -360,7 +360,7 @@ static inline void tty_set_operations(struct tty_driver *driver,
>   * 	Used for PTY's, in particular.
>   * 
>   * TTY_DRIVER_REAL_RAW --- if set, indicates that the driver will
> - * 	guarantee never not to set any special character handling
> + * 	guarantee never to set any special character handling
>   * 	flags if ((IGNBRK || (!BRKINT && !PARMRK)) && (IGNPAR ||
>   * 	!INPCK)).  That is, if there is no reason for the driver to
>   * 	send notifications of parity and break characters up to the



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux