On Tue, Oct 26, 2021 at 08:45:48PM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on tty/tty-testing] > [cannot apply to v5.15-rc7 next-20211026] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing > config: i386-randconfig-a003-20211025 (attached as .config) > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a461fa64bb37cffd73f683c74f6b0780379fc2ca) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/24a32531ba63f472ec6f40c4d431cb5369b29818 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Andy-Shevchenko/serial-8250_pci-Replace-custom-pci_match_id-implementation/20211025-204752 > git checkout 24a32531ba63f472ec6f40c4d431cb5369b29818 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > >> drivers/tty/serial/8250/8250_pci.c:1268:6: warning: variable 'amcc' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > if (match) > ^~~~~ > drivers/tty/serial/8250/8250_pci.c:1273:6: note: uninitialized use occurs here > if (amcc) { > ^~~~ > drivers/tty/serial/8250/8250_pci.c:1268:2: note: remove the 'if' if its condition is always true > if (match) > ^~~~~~~~~~ > drivers/tty/serial/8250/8250_pci.c:1265:11: note: initialize the variable 'amcc' to silence this warning > bool amcc; > ^ > = 0 Clang gives a right and wrong advice at the same time. Thank you for the uninitialized case, but variable is boolean, what's 0 here? I'll send a fix ASAP. > 1 warning generated. -- With Best Regards, Andy Shevchenko
