On Mon, Oct 18, 2021 at 10:42:13AM +0200, Greg KH wrote: > On Mon, Oct 18, 2021 at 01:50:00PM +0530, Shubhrajyoti Datta wrote: > > Update the default number of uarts. > > The commit b44b96a060f3 changed the default from 16 to 1 change it back to 16. > > > > Fixes: b44b96a060f3 (uartlite: Adding a kernel parameter for the number of uartlites) > > > > No extra line here please. > > Also, your subject is odd, please make it more obvious what is > happening. > > But nost importantly, _WHY_ are you making this change? What happened > since that commit was made that now we should have the default be 16? > Previously that commit said the default should NOT be 16, and here you > are changing it back. What changed to require this? Also, you failed to cc: the author of that commit, which isn't the most kind thing to do. Please do so when you resubmit this with the requested changes. thanks, greg k-h
