On Fri, Oct 01, 2021 at 12:31:34AM +0900, Daniel Palmer wrote: > On Fri, 1 Oct 2021 at 00:24, Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > And incorrect fix. See my patches regarding to the topic > > (`git log --grep ACPI_PTR`) and do accordingly, i.e. drop > > ACPI_PTR() for good. > > Something like 349bff48ae0f5f8aa2075d0bdc2091a30bd634f6? > > Doesn't this mean the ACPI table ends up in kernels that will never use ACPI? Yes. Is it a problem (*)? If so, you need to use ifdeffery, since __maybe_unused is not for the ID tables. *) while justifying this you also need to show why it's a problem specific to the ACPI IDs and not a problem for OF ones, which we have tons of in the Linux kernel without any guards (ifdeffery). -- With Best Regards, Andy Shevchenko
