On Mon, Sep 27, 2021 at 3:45 PM Pali Rohár <pali@xxxxxxxxxx> wrote: > > On Monday 27 September 2021 15:17:59 Rob Herring wrote: > > On Wed, Sep 22, 2021 at 5:56 AM Pali Rohár <pali@xxxxxxxxxx> wrote: > > > > > > This change adds DT bindings documentation for device nodes with compatible > > > string "marvell,armada-3700-uart-clock". > > > > Please resend to the DT list so that checks run and this gets reviewed > > in a timely manner. > > > > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > > > --- > > > .../bindings/clock/armada3700-uart-clock.yaml | 57 +++++++++++++++++++ > > > 1 file changed, 57 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml b/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml > > > new file mode 100644 > > > index 000000000000..5bdb23e0ba3e > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml > > > @@ -0,0 +1,57 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > > Dual license. checkpatch will tell you which ones. > > Did not tell me :-( > > $ ./scripts/checkpatch.pl -f Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in <module> > from ply import lex, yacc > ModuleNotFoundError: No module named 'ply' > total: 0 errors, 0 warnings, 57 lines checked > > Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml has no obvious style problems and is ready for submission. > > Huh, Perl needs Python?? Anyway... > > $ sudo apt install python3-ply > ... > > $ ./scripts/checkpatch.pl -f Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 10, in <module> > import git > ModuleNotFoundError: No module named 'git' > total: 0 errors, 0 warnings, 57 lines checked > > Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml has no obvious style problems and is ready for submission. > > Second attempt... > > $ sudo apt install python3-git > ... > > $ ./scripts/checkpatch.pl -f Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml > total: 0 errors, 0 warnings, 57 lines checked > > Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml has no obvious style problems and is ready for submission. > > And no error :-( Looks like file mode requires '--strict' to enable while patch mode doesn't. Rob
