On 14.09.2021 11:11:23, Jiri Slaby wrote: > The only user of 'file' parameter in tty_mode_ioctl is a BUG_ON check. > Provided it never crashed for anyone, it's an overkill to pass the > parameter to tty_mode_ioctl only for this check. > > If we wanted to check 'file' there, we should handle it in more graceful > way anyway. Not by a BUG == crash. > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> > Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Andreas Koensgen <ajk@xxxxxxxxxxxxxxxxxxxxx> > Cc: Paul Mackerras <paulus@xxxxxxxxx> > --- > drivers/net/can/slcan.c | 2 +- For the slcan.c: Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
