On 13.08.21 19:53, Rob Herring wrote: > On Thu, Aug 05, 2021 at 02:54:22PM +0800, Chester Lin wrote: >> Add bindings for S32G2's evaluation board (S32G-VNP-EVB) and reference >> design 2 board ( S32G-VNP-RDB2). >> >> Signed-off-by: Chester Lin <clin@xxxxxxxx> >> --- >> Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >> index e2097011c4b0..3914aa09e503 100644 >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >> @@ -983,6 +983,13 @@ properties: >> - const: solidrun,lx2160a-cex7 >> - const: fsl,lx2160a >> >> + - description: S32G2 based Boards >> + items: >> + - enum: >> + - fsl,s32g274a-evb >> + - fsl,s32g274a-rdb2 >> + - const: fsl,s32g2 > > Given this is an entirely different family from i.MX and new?, shouldn't > it use 'nxp' instead of 'fsl'? S32V also still used fsl prefix, despite the company name long being NXP (same for several Layerscape and i.MX models). If, as Radu indicated on 3/8, NXP wants to make that switch now for S32G then I see no reason against nxp. I verified that it's already defined: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/vendor-prefixes.yaml However, should the matching .dts[i] files using nxp prefix (4-6/8) then still go under dts/freescale/, or should they go to a new dts/nxp/ then? That would separate it from S32V. Intel did do a switch from dts/altera/ to dts/intel/ at some point, so there's precedence for either, I guess. No idea whether anything might break if we moved S32V alongside S32G. Similarly, the easiest and most merge-friendly would be to leave arm/fsl.yaml and add the nxp-prefixed S32G2 there, as done here. If NXP want to rename fsl.yaml to nxp.yaml in a general housekeeping effort, that could be done independently, outside Chester's patchset. > Either way, > > Acked-by: Rob Herring <robh@xxxxxxxxxx> Thanks, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)
