On Fri, Aug 13, 2021 at 04:09:50PM +0100, Robin Murphy wrote: > On 2021-08-13 16:01, gregkh wrote: > > On Fri, Aug 13, 2021 at 09:42:52AM -0400, Qian Cai wrote: > > > > > > > > > On 8/12/2021 11:32 PM, tombinfan(范兵) wrote: > > > > hello, > > > > > > > > I have sent the modified patch to the following mailboxes. THX > > > > > > > > gregkh@xxxxxxxxxxxxxxxxxxx > > > > linux-serial@xxxxxxxxxxxxxxx > > > > linux-kernel@xxxxxxxxxxxxxxx > > > > > > Thanks for the pointer. It is good to get some reviews from Arm > > > people in the first place, so we don't break Arm like this. > > > > > > Anyway, for anyone who might be watching, here is the new patch, > > > > > > https://lore.kernel.org/linux-serial/1628825490-18937-1-git-send-email-hptsfb@xxxxxxxxx/ > > > > > > Unfortunately, I saw Greg mentioned that it was not based on > > > tty-next, so not something I can apply easily on linux-next here > > > as well. > > > > That is because the code in tty-next (and linux-next), looks to already > > do exactly what you submitted, right? > > > > So is this working now for everyone in linux-next? > > AFAICS commit b0819465be8b in linux-next still results in > amba_device-specific code being called from sbsa_uart_startup() and > sbsa_uart_shutdown(), which is what blows up. Ick, ok, can someone send me a revert with this information in it please? thanks, greg k-h
