On Wed, Jul 7, 2021 at 4:14 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Monday, July 5, 2021, Zheyu Ma <zheyuma97@xxxxxxxxx> wrote: >> >> In function 'neo_intr', the driver uses 'ch->ch_equeue' and >> 'ch->ch_reuque'. These two pointers are initialized in 'jsm_tty_open', >> but the interrupt handler 'neo_intr' has been registered in the probe >> progress. If 'jsm_tty_open' has not been called at this time, it will >> cause null pointer dereference. >> >> Once the driver registers the interrupt handler, the driver should be >> ready to handle it. >> >> Fix this by allocating the memory at probe time and not at open time. >> >> This log reveals it: > > > > When doing commit messages try to avoid tons of noise in them, I.e. here is _a lot of useless lines_ from the log, has to be addressed. Thanks for your advice, I will learn from other commits. Regards, Zheyu Ma