> -----Original Message----- > From: Tamseel Shams <m.shams@xxxxxxxxxxx> > Sent: Monday, June 21, 2021 10:18 AM > To: kgene@xxxxxxxxxx; krzk@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > jslaby@xxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; > linux-serial@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > alim.akhtar@xxxxxxxxxxx; ajaykumar.rs@xxxxxxxxxxx; Tamseel Shams > <m.shams@xxxxxxxxxxx> > Subject: [PATCH v4] serial: samsung: change to platform_get_irq_optional > > In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP is having > 2 interrupt lines. > However, in other SoCs like s3c6400, s5pv210, exynos5433, and exynos4210 > UART is having only 1 interrupt line. Due to this, "platform_get_irq(platdev, 1)" > call in the driver gives the following false-positive error: > "IRQ index 1 not found" on recent platforms. > > This patch replaces the platform_get_irq() call with > platform_get_irq_optional() and hence avoiding the false-positive error. > > Signed-off-by: Tamseel Shams <m.shams@xxxxxxxxxxx> > --- > Commit message is changed. > Addressed Krzysztof's previous comment. > > drivers/tty/serial/samsung_tty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c > index 6ef614d8648c..c44582011b9b 100644 > --- a/drivers/tty/serial/samsung_tty.c > +++ b/drivers/tty/serial/samsung_tty.c > @@ -1911,7 +1911,7 @@ static int s3c24xx_serial_init_port(struct > s3c24xx_uart_port *ourport, > ourport->tx_irq = ret + 1; > } > > - ret = platform_get_irq(platdev, 1); > + ret = platform_get_irq_optional(platdev, 1); > if (ret > 0) > ourport->tx_irq = ret; > /* > -- > Please ignore this patch. Sorry for the spam. Thanks & Regards, Tamseel Shams
