On Tue, Jun 08, 2021 at 04:17:58PM +0300, Maxim Levitsky wrote: > Hi! > > I happened to own one of Exar's PCI serial adapters, and this commit that I bisected > breaks suspend/resume of the host. > > The adapter that I have: > > 02:00.0 Serial controller [0700]: Exar Corp. XR17V3521 Dual PCIe UART [13a8:0352] (rev 03) (prog-if 02 [16550]) > > > First suspend of the system works,but on the second suspend, the system hangs until it reboots. > Reverting the commit helps. > > I attached a backtrace captured with ramoops > (since I ironically use this serial port to capture the oops backtraces otherwise...) Thanks for the report, can you check if adding if (pdev) before device_remove_software_node(&pdev->dev); helps? -- With Best Regards, Andy Shevchenko