From: Zihao Tang <tangzihao1@xxxxxxxxxxxxx> Fix 4 coding style warnings reported by checkpatch.pl. There is 1 "labels should not be indented" warning, and the remaining 3 warnings are "Missing a blank line after declarations". Signed-off-by: Zihao Tang <tangzihao1@xxxxxxxxxxxxx> Signed-off-by: Jay Fang <f.fangjian@xxxxxxxxxx> --- drivers/tty/serial/apbuart.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/apbuart.c b/drivers/tty/serial/apbuart.c index d8c937b..196b571 100644 --- a/drivers/tty/serial/apbuart.c +++ b/drivers/tty/serial/apbuart.c @@ -113,7 +113,7 @@ static void apbuart_rx_chars(struct uart_port *port) uart_insert_char(port, rsr, UART_STATUS_OE, ch, flag); - ignore_char: +ignore_char: status = UART_GET_STATUS(port); } @@ -175,6 +175,7 @@ static irqreturn_t apbuart_int(int irq, void *dev_id) static unsigned int apbuart_tx_empty(struct uart_port *port) { unsigned int status = UART_GET_STATUS(port); + return status & UART_STATUS_THE ? TIOCSER_TEMT : 0; } @@ -311,6 +312,7 @@ static int apbuart_verify_port(struct uart_port *port, struct serial_struct *ser) { int ret = 0; + if (ser->type != PORT_UNKNOWN && ser->type != PORT_APBUART) ret = -EINVAL; if (ser->irq < 0 || ser->irq >= NR_IRQS) @@ -416,6 +418,7 @@ static void apbuart_flush_fifo(struct uart_port *port) static void apbuart_console_putchar(struct uart_port *port, int ch) { unsigned int status; + do { status = UART_GET_STATUS(port); } while (!UART_TX_READY(status)); -- 2.7.4