Re: [PATCH 01/35] tty: remove broken r3964 line discipline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 05, 2021 at 11:18:54AM +0200, Jiri Slaby wrote:
> Noone stepped up in the past two years since it was marked as BROKEN by
> commit c7084edc3f6d (tty: mark Siemens R3964 line discipline as BROKEN).
> Remove the line discipline for good.
> 
> Three remarks:
> * we remove also the uapi header (as noone is able to use that interface
>   anyway)
> * we do *not* remove the N_R3964 constant definition from tty.h, so it
>   remains reserved.
> * in_interrupt() check is now removed from vt's con_put_char. Noone else
>   calls tty_operations::put_char from interrupt context.
> 
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> ---
>  arch/powerpc/configs/ppc6xx_defconfig |    1 -
>  drivers/char/Kconfig                  |   13 -
>  drivers/tty/Makefile                  |    1 -
>  drivers/tty/n_r3964.c                 | 1283 -------------------------
>  drivers/tty/vt/vt.c                   |    2 -
>  include/linux/n_r3964.h               |  175 ----
>  include/uapi/linux/n_r3964.h          |   99 --
>  7 files changed, 1574 deletions(-)
>  delete mode 100644 drivers/tty/n_r3964.c
>  delete mode 100644 include/linux/n_r3964.h
>  delete mode 100644 include/uapi/linux/n_r3964.h

Oh yes, thank you!  I guess no one really cares about this anymore,
thanks for removing it.

greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux