On Wed, Apr 28, 2021 at 09:30:52AM +0200, Christophe JAILLET wrote:
> This fixes the following checkpatch.pl warnings:
> WARNING: Missing a blank line after declarations
> WARNING: braces {} are not necessary for any arm of this statement
If it makes somebody happier...
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 081b773a54c9..1082e76c4d37 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -321,9 +321,9 @@ static int univ8250_setup_irq(struct uart_8250_port *up)
> * hardware interrupt, we use a timer-based system. The original
> * driver used to do this with IRQ0.
> */
> - if (!port->irq) {
> + if (!port->irq)
> mod_timer(&up->timer, jiffies + uart_poll_timeout(port));
> - } else
> + else
> retval = serial_link_irq_chain(up);
>
> return retval;
> @@ -752,6 +752,7 @@ void serial8250_suspend_port(int line)
> if (!console_suspend_enabled && uart_console(port) &&
> port->type != PORT_8250) {
> unsigned char canary = 0xa5;
> +
> serial_out(up, UART_SCR, canary);
> if (serial_in(up, UART_SCR) == canary)
> up->canary = canary;
> --
> 2.30.2
>
--
With Best Regards,
Andy Shevchenko
