[PATCH] serial: sh-sci: correct units in comment about DMA timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Since the transition to hrtimers, the calculation does not involve jiffies
any longer, which has led to confusion. State the times in ms instead.

Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
---
 drivers/tty/serial/sh-sci.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index e3af97a59856..c4ce4cd120ba 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -2613,11 +2613,11 @@ static void sci_set_termios(struct uart_port *port, struct ktermios *termios,
 	 * Calculate delay for 2 DMA buffers (4 FIFO).
 	 * See serial_core.c::uart_update_timeout().
 	 * With 10 bits (CS8), 250Hz, 115200 baud and 64 bytes FIFO, the above
-	 * function calculates 1 jiffie for the data plus 5 jiffies for the
-	 * "slop(e)." Then below we calculate 5 jiffies (20ms) for 2 DMA
-	 * buffers (4 FIFO sizes), but when performing a faster transfer, the
-	 * value obtained by this formula is too small. Therefore, if the value
-	 * is smaller than 20ms, use 20ms as the timeout value for DMA.
+	 * function calculates 4ms for the data plus 20ms for the "slop(e)."
+	 * Then below we calculate 20ms for 2 DMA buffers (4 FIFO sizes),
+	 * but when performing a faster transfer, the value obtained by this
+	 * formula is too small. Therefore, if the value is smaller than
+	 * 20ms, use 20ms as the timeout value for DMA.
 	 */
 	s->rx_frame = (10000 * bits) / (baud / 100);
 #ifdef CONFIG_SERIAL_SH_SCI_DMA
-- 
2.20.1




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux