On Wed, Mar 03, 2021 at 08:17:11PM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 02, 2021 at 07:22:07AM +0100, Jiri Slaby wrote: > > Forward declarations make the code larger, harder to follow and rewrite. > > Harder as the declarations are often omitted from global changes. Remove > > forward declarations which are not really needed, i.e. when the > > definition of the function is before its first use. > > > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > > Cc: Johan Hovold <johan@xxxxxxxxxx> > > --- > > drivers/usb/serial/keyspan.c | 20 -------------------- > > 1 file changed, 20 deletions(-) > > I'll let Johan take this through his tree: > > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Thanks, I'll pick these two up next week. Jiri, was there ever a cover letter to this series? It took a while for all 44 (!) patches to hit the lists (or my inbox), but I never could figure out whether there was an overall theme to it that made you post it all as a single series in the first place. Johan
