Re: [PATCH 34/44] tty: do not check tty_unregister_driver's return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 1, 2021 at 10:22 PM Jiri Slaby <jslaby@xxxxxxx> wrote:
>
> These drivers check tty_unregister_driver return value. But they don't
> handle a failure correctly (they free the driver in any case). So stop
> checking tty_unregister_driver return value and remove also the prints.
>
> In the next patch, tty_unregister_driver's return type will be switched
> to void.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Chris Zankel <chris@xxxxxxxxxx>
> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx>
> Cc: linux-xtensa@xxxxxxxxxxxxxxxx
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: David Sterba <dsterba@xxxxxxxx>
> ---
>  arch/xtensa/platforms/iss/console.c | 6 +-----
>  drivers/tty/amiserial.c             | 8 ++------
>  drivers/tty/ipwireless/tty.c        | 7 +------
>  drivers/tty/moxa.c                  | 4 +---
>  drivers/tty/serial/kgdb_nmi.c       | 4 +---
>  drivers/tty/synclink_gt.c           | 5 +----
>  6 files changed, 7 insertions(+), 27 deletions(-)

Reviewed-by: Max Filippov <jcmvbkbc@xxxxxxxxx>

-- 
Thanks.
-- Max



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux