On Tue, Feb 23, 2021 at 04:06:30PM +0800, dingsenjie@xxxxxxx wrote: > From: dingsenjie <dingsenjie@xxxxxxxxxx> > > Remove superfluous "breaks", as there is a "return" before them. > > Signed-off-by: dingsenjie <dingsenjie@xxxxxxxxxx> You are at least the fourth person who sends this patch[1]. The things I wrote in reply to the latest submission still applies: - the Subject is wrong, it should use a prefix similar to "serial: imx:". - I personally like the breaks for clarity. - If people agree enough to outvote me, please at least add an empty line instead of just removing the break to visually separate the cases. Thanks Uwe [1] https://lore.kernel.org/r/20201026125142.21105-1-zhangqilong3@xxxxxxxxxx https://lore.kernel.org/r/20201020130709.28096-1-trix@xxxxxxxxxx https://lore.kernel.org/r/20201107140129.kpfhanzjidvdg662@xxxxxxxxxxxxxx -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
