Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alex Nemirovsky <alex.nemirovsky@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Feb 2021 16:49:52 +0100
Cc: Jiri Slaby <jirislaby@xxxxxxxxxx>, Jason Li <jason.li@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx
In-reply-to: <1612425530-20483-1-git-send-email-alex.nemirovsky@cortina-access.com>
References: <1612425530-20483-1-git-send-email-alex.nemirovsky@cortina-access.com>

On Wed, Feb 03, 2021 at 11:58:47PM -0800, Alex Nemirovsky wrote:
> +static uintptr_t *cortina_uart_ports;

Note, "uintptr_t" is not a valid kernel type.

Please use a pointer to a real thing, no void pointers please.

thanks,

greg k-h

Follow-Ups:
- Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform
  - From: Alex Nemirovsky

Prev by Date: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform
Next by Date: Re: [PATCH v4] tty: make pl011 serial port driver support 485 mode
Previous by thread: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform
Next by thread: Re: [PATCH 1/3] tty: serial: Add UART driver for Cortina-Access platform
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]

Powered by Linux