Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021-01-29 6:25 a.m., Andy Shevchenko wrote:
> On Thu, Jan 28, 2021 at 06:36:29PM -0500, Eric Tremblay wrote:
>> That port does not have an interrupt on TEMT when using
>> the FIFO mode.
> This is wrong.
> 1. You have to guarantee that TEMT is set for all UARTs before this patch
> 2. World is not staying on OF only platforms
>
> NAK

Considering the use of the reversed capability UART_CAP_NOTEMT should I set
the flag directly in uart_config like:

[PORT_16550A_FSL64] = {
		.name		= "16550A_FSL64",
		.fifo_size	= 64,
		.tx_loadsz	= 63,
		.fcr		= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
				  UART_FCR7_64BYTE,
		.flags		= UART_CAP_FIFO | UART_CAP_NOTEMT,
	},

>




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux