Re: [PATCH v3 4/5] amba: Make the remove callback return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v3 4/5] amba: Make the remove callback return void
From: Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx>
Date: Tue, 26 Jan 2021 19:05:11 +0000
Cc: Suzuki K Poulose <suzuki.poulose@xxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Matt Mackall <mpm@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Eric Anholt <eric@xxxxxxxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Vladimir Zapolskiy <vz@xxxxxxxxx>, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Eric Auger <eric.auger@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, linux-rtc@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-fbdev@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, coresight@xxxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, Leo Yan <leo.yan@xxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Mike Leach <mike.leach@xxxxxxxxxx>
In-reply-to: <20210126175652.3caoqfnsky2es42f@pengutronix.de>
References: <20210126165835.687514-1-u.kleine-koenig@pengutronix.de> <20210126165835.687514-5-u.kleine-koenig@pengutronix.de> <3e42b2ea-c713-31b2-9c86-c49a70d8e1f4@arm.com> <20210126175652.3caoqfnsky2es42f@pengutronix.de>
User-agent: Mutt/1.10.1 (2018-07-13)

On Tue, Jan 26, 2021 at 06:56:52PM +0100, Uwe Kleine-König wrote:
> I'm surprised to see that the remove callback introduced in 2952ecf5df33
> ("coresight: etm4x: Refactor probing routine") has an __exit annotation.

In general, remove callbacks should not have an __exit annotation.
__exit _can_ be discarded at link time for built-in stuff.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

References:
- [PATCH v3 0/5] amba: minor fix and various cleanups
  - From: Uwe Kleine-König
- [PATCH v3 4/5] amba: Make the remove callback return void
  - From: Uwe Kleine-König
- Re: [PATCH v3 4/5] amba: Make the remove callback return void
  - From: Suzuki K Poulose
- Re: [PATCH v3 4/5] amba: Make the remove callback return void
  - From: Uwe Kleine-König

Prev by Date: Re: [PATCH v3 4/5] amba: Make the remove callback return void
Next by Date: Re: [PATCH v3 4/5] amba: Make the remove callback return void
Previous by thread: Re: [PATCH v3 4/5] amba: Make the remove callback return void
Next by thread: Re: [PATCH v3 4/5] amba: Make the remove callback return void
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]