On Wed, Nov 04, 2020 at 07:35:26PM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/tty/serial/8250/8250_port.c:349:14: warning: no previous prototype for ‘au_serial_in’ [-Wmissing-prototypes] > drivers/tty/serial/8250/8250_port.c:359:6: warning: no previous prototype for ‘au_serial_out’ [-Wmissing-prototypes] > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Jiri Slaby <jirislaby@xxxxxxxxxx> > Cc: Mike Hudson <Exoray@xxxxxxx> > Cc: linux-serial@xxxxxxxxxxxxxxx > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_port.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) And now I get build errors of: ld: drivers/tty/serial/8250/8250_early.o: in function `early_au_setup': 8250_early.c:(.init.text+0x7): undefined reference to `au_serial_in' ld: 8250_early.c:(.init.text+0xf): undefined reference to `au_serial_out' make: *** [Makefile:1164: vmlinux] Error 1 Always test-build your patches, perhaps W=1 was wrong here... thanks, greg k-h
