From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: 2020-11-04 19:02:53
To: Bernard Zhao <bernard@xxxxxxxx>
Cc: Jiri Slaby <jirislaby@xxxxxxxxxx>,Shawn Guo <shawnguo@xxxxxxxxxx>,Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>,Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>,Fabio Estevam <festevam@xxxxxxxxx>,NXP Linux Team <linux-imx@xxxxxxx>,linux-kernel@xxxxxxxxxxxxxxx,linux-serial@xxxxxxxxxxxxxxx,linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,opensource.kernel@xxxxxxxx
Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto>On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote:
>> This patch sereies optimise code like:
>> {
>> case XXX:
>> return XXX;
>> break; //The break is meanless, so just delete it.
>> case YYY:
>> goto YYY;
>> break; //The break is meanless, so just delete it.
>> ......
>> }
>>
>> Signed-off-by: Bernard Zhao <bernard@xxxxxxxx>
>>
>> ---
>> Bernard Zhao (2):
>> drivers/tty/nozomi.c: delete no use break after goto
>> drivers/tty/serial/imx.c: delete no use break after return
>
>That is not the subject of the patches you sent out, what broke?
Hi:
I am sorry that I am a little confused:
The patch series`s subject is "drivers/tty: delete break after return or goto"
and the blurb is:
This patch sereies optimise code like:
{
case XXX:
return XXX;
break; //The break is meanless, so just delete it.
case YYY:
goto YYY;
break; //The break is meanless, so just delete it.
......
}
last, the modified files are:
Bernard Zhao (2):
drivers/tty/nozomi.c: delete no use break after goto
drivers/tty/serial/imx.c: delete no use break after return
Is there something wrong that I didn`t catch?
BR//Bernard
