hello, On Mon, Oct 26, 2020 at 08:51:42PM +0800, Zhang Qilong wrote: > The 'break' is not possoble to be reached s/possoble/possible/ > because of previous 'return', discard it. Given that this such a patch was already sent a week ago[1], I wonder if there is a tool that complains here? If so, mentioning it in the commit log would be good. Other than that I still think that there should be at least an empty line instead of the break, as I already wrote in reply to the first patch. And having said that I also don't think this is worth "fixing", seeing the break in a switch statement is good for human readers. Best regards Uwe [1] https://lore.kernel.org/r/20201019175915.3718-1-trix@xxxxxxxxxx -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
