On Tue, Aug 18, 2020 at 10:56:52AM +0200, Jiri Slaby wrote: > That is: > 1) call the parameter 'xy' to denote what it really is, not generic 'p' > 2) tell the compiler and users that we expect an array: > * with at least 2 chars (static 2) > * which we don't modify in putconsxy (const) > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > --- > drivers/tty/vt/vt.c | 10 +++++----- > include/linux/selection.h | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > index 8f283221330e..a0da7771c327 100644 > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c > @@ -4769,17 +4769,17 @@ unsigned short *screen_pos(const struct vc_data *vc, int w_offset, int viewed) > } > EXPORT_SYMBOL_GPL(screen_pos); > > -void getconsxy(const struct vc_data *vc, unsigned char *p) > +void getconsxy(const struct vc_data *vc, unsigned char xy[static 2]) I didn't realize we could do "[static 2]" in the kernel now, is that thanks to the bump of the minimum gcc version? If so, nice! thanks, greg k-h
