On Thu, Aug 13, 2020 at 12:52:55PM -0400, Valmer Huhn wrote:
Thanks for an update, my comments below.
> The following in 8250_exar.c line 589 is used to determine the number
> of ports for each Exar board:
>
> nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f;
>
> If the number of ports a card has is not explicitly specified, it defaults
> to the rightmost 4 bits of the PCI device ID. This is prone to error since
> not all PCI device IDs contain a number which corresponds to the number of
> ports that card provides.
>
> This particular case involves COMMTECH_4222PCIE, COMMTECH_4224PCIE and
> COMMTECH_4228PCIE cards with device IDs 0x0022, 0x0020 and 0x0021.
> Currently the multiport cards receive 2, 0 and 1 port instead of 2, 4 and
> 8 ports respectively.
>
> To fix this, each Commtech Fastcom PCIe card is given a struct where the
> number of ports is explicitly specified. This ensures 'board->num_ports'
> is used instead of the default 'pcidev->device & 0x0f'.
...
> Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
>
Shouldn't be blank line here.
> Signed-off-by: Valmer Huhn <valmer.huhn@xxxxxxxxxxxxxxxxx>
...
> Tested-by: Valmer Huhn <valmer.huhn@xxxxxxxxxxxxxxxxx>
This tag (Tested-by: Author_of_the_patch) is implied. We don't want patches
that weren't tested by authors.
After cutter line '---' you missed to provide a changelog along with bumping
patch version. Hint, use -v<X> when run `git format-patch ...`
P.S. Next should be v3, so `git format-patch -v3 ...`.
--
With Best Regards,
Andy Shevchenko
