On Fri, Jul 24, 2020 at 11:44:02AM +0530, Paras Sharma wrote: > To correct the logic to detect whether the QUP HW version is greater > than 2.5. The subject line and here does not make any sense. Can you reword this as what the problem is and why you need to change this? > > Signed-off-by: Paras Sharma <parashar@xxxxxxxxxxxxxx> > --- > drivers/tty/serial/qcom_geni_serial.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 1ed3d35..5b0efb49 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -954,7 +954,8 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport, > sampling_rate = UART_OVERSAMPLING; > /* Sampling rate is halved for IP versions >= 2.5 */ > ver = geni_se_get_qup_hw_version(&port->se); > - if (GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5) > + if ((GENI_SE_VERSION_MAJOR(ver) >= 2 && GENI_SE_VERSION_MINOR(ver) >= 5) > + || GENI_SE_VERSION_MAJOR(ver) >= 3) Odd coding style :( Please fix all of the above up and resubmit a v2. thanks, greg k-h
