From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> Sent: Friday, July 17, 2020 5:42 PM > On Fri, Jul 17, 2020 at 09:33:20AM +0000, Andy Duan wrote: > > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> Sent: Friday, July 17, 2020 > > 4:58 PM > > > On Fri, Jul 17, 2020 at 04:18:27PM +0800, Fugang Duan wrote: > > > > GKI kernel requires drivers built as modules including console > > > > driver, so add the support that imx serial console driver can be > > > > built as module. > > > > > > > > The changes of the patch: > > > > - imx console driver can be built as module. > > > > - move out earlycon code to separated driver like imx_earlycon.c, > > > > and imx earlycon driver only support build-in. > > > > > > > > v2: > > > > - fix kbuild error > > > > > > > > Signed-off-by: Fugang Duan <fugang.duan@xxxxxxx> > > > > --- > > > > drivers/tty/serial/Kconfig | 18 +++++++---- > > > > drivers/tty/serial/Makefile | 1 + > > > > drivers/tty/serial/imx.c | 37 ++--------------------- > > > > drivers/tty/serial/imx_earlycon.c | 50 > > > > +++++++++++++++++++++++++++++++ > > > > 4 files changed, 66 insertions(+), 40 deletions(-) > > > > > > > > diff --git a/drivers/tty/serial/Kconfig > > > > b/drivers/tty/serial/Kconfig index 780908d43557..dabd06ca9b66 > > > > 100644 > > > > --- a/drivers/tty/serial/Kconfig > > > > +++ b/drivers/tty/serial/Kconfig > > > > @@ -502,20 +502,28 @@ config SERIAL_IMX > > > > can enable its onboard serial port by enabling this option. > > > > > > > > config SERIAL_IMX_CONSOLE > > > > - bool "Console on IMX serial port" > > > > - depends on SERIAL_IMX=y > > > > + tristate "Console on IMX serial port" > > > > + depends on SERIAL_IMX > > > > select SERIAL_CORE_CONSOLE > > > > - select SERIAL_EARLYCON if OF > > > > help > > > > If you have enabled the serial port on the Freescale IMX > > > > - CPU you can make it the console by answering Y to this option. > > > > + CPU you can make it the console by answering Y/M to this > option. > > > > > > > > - Even if you say Y here, the currently visible virtual console > > > > + Even if you say Y/M here, the currently visible virtual > > > > + console > > > > (/dev/tty0) will still be used as the system console by default, > but > > > > you can alter that using a kernel command line option such > as > > > > "console=ttymxc0". (Try "man bootparam" or see the > > > documentation of > > > > your bootloader about how to pass options to the kernel at > > > > boot time.) > > > > > > > > +config SERIAL_IMX_EARLYCON > > > > + bool "Earlycon on IMX serial port" > > > > + depends on OF > > > > + select SERIAL_EARLYCON > > > > + default y > > > > > > Only put "default y" if you can not boot a machine without this. > > > Otherwise leave the default line off, it will be 'n' and can be > > > selected if a user wants that. > > > > > > That should be the case here, please change this. > > > > I will change it to "default n" in next version, thanks. > > No, just remove the line, the default is 'n' with no default specified. Got it, it makes sense. Thanks! > > thanks, > > greg k-h
