On Mon, Jul 06, 2020 at 05:00:36PM +0300, Andy Shevchenko wrote:
> The comment near to uart_port_spin_lock_init() says:
>
> Ensure that the serial console lock is initialised early.
> If this port is a console, then the spinlock is already initialised.
>
> and there is nothing about enabled or disabled consoles. The commit
> a3cb39d258ef ("serial: core: Allow detach and attach serial device
> for console") made a change, which follows the comment, and also to
> prevent reinitialisation of the lock in use, when user detaches and
> attaches back the same console device. But this change discovers
> another issue, that uart_add_one_port() tries to access a spin lock
> that now may be uninitialised. This happens when a driver expects
> the serial core to register a console on its behalf. In this case
> we must initialise a spin lock before use.
Abandon this version, please, I forgot to squash it with the typo fix.
v2 has been sent.
--
With Best Regards,
Andy Shevchenko
