On 30-06-20, 08:31, Rajendra Nayak wrote: > > > On 6/30/2020 4:47 AM, Stephen Boyd wrote: > > Quoting Rajendra Nayak (2020-06-15 05:02:39) > > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > > > index 457c0bf..a90f8ec 100644 > > > --- a/drivers/tty/serial/qcom_geni_serial.c > > > +++ b/drivers/tty/serial/qcom_geni_serial.c > > > @@ -9,6 +9,7 @@ > > > #include <linux/module.h> > > > #include <linux/of.h> > > > #include <linux/of_device.h> > > > +#include <linux/pm_opp.h> > > > #include <linux/platform_device.h> > > > #include <linux/pm_runtime.h> > > > #include <linux/pm_wakeirq.h> > > > @@ -962,7 +963,7 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport, > > > goto out_restart_rx; > > > uport->uartclk = clk_rate; > > > - clk_set_rate(port->se.clk, clk_rate); > > > + dev_pm_opp_set_rate(uport->dev, clk_rate); > > > > If there isn't an OPP table for the device because it is optional then > > how can we unconditionally call dev_pm_opp_set_rate()? Looks like some *Maintainers* aren't paying enough attention lately ;) Just kidding. > because we have 'aca48b6 opp: Manage empty OPP tables with clk handle' to handle this. -- viresh
