On (20/06/18 19:47), Andy Shevchenko wrote:
> Some of the console providers treat error code, returned by ->setup() hook,
> differently. Here is the unification of the behaviour.
>
> The drivers checked by one of the below criteria:
> 1/ the driver has explicit struct console .setup assignment
> 2/ the driver has assigned callback to the setup member
>
> All such drivers were read in order to see if there is any problematic return
> codes, and fixed accordingly which is this series in the result.
>
> Andy Shevchenko (6):
> mips: Return proper error code from console ->setup() hook
> serial: sunsab: Return proper error code from console ->setup() hook
> serial: sunzilog: Return proper error code from console ->setup() hook
> tty: hvc: Return proper error code from console ->setup() hook
> console: Propagate error code from console ->setup()
> console: Fix trivia typo 'change' -> 'chance'
>
> arch/mips/fw/arc/arc_con.c | 4 +++-
> drivers/tty/hvc/hvsi.c | 2 +-
> drivers/tty/serial/sunsab.c | 2 +-
> drivers/tty/serial/sunzilog.c | 2 +-
> kernel/printk/printk.c | 8 ++++----
> 5 files changed, 10 insertions(+), 8 deletions(-)
Looks good to me. I'd also, probably, unify the naming. I can grep
71 foo_console_setup() and only 1 foo_setup_console().
---
drivers/tty/hvc/hvc_xen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
index 5ef08905fe05..2a0e51a20e34 100644
--- a/drivers/tty/hvc/hvc_xen.c
+++ b/drivers/tty/hvc/hvc_xen.c
@@ -603,7 +603,7 @@ static void xen_hvm_early_write(uint32_t vtermno, const char *str, int len) { }
#endif
#ifdef CONFIG_EARLY_PRINTK
-static int __init xenboot_setup_console(struct console *console, char *string)
+static int __init xenboot_console_setup(struct console *console, char *string)
{
static struct xencons_info xenboot;
@@ -647,7 +647,7 @@ static void xenboot_write_console(struct console *console, const char *string,
struct console xenboot_console = {
.name = "xenboot",
.write = xenboot_write_console,
- .setup = xenboot_setup_console,
+ .setup = xenboot_console_setup,
.flags = CON_PRINTBUFFER | CON_BOOT | CON_ANYTIME,
.index = -1,
};
--
2.27.0
