On Thu, Jun 11, 2020 at 10:25:30AM +0200, Lukas Wunner wrote: > [cc += Heiko] > > On Wed, Jun 10, 2020 at 05:51:21PM +0200, Johan Hovold wrote: > > Drop the recently added gpio include from the serial-core header in > > favour of a forward declaration and instead include the gpio header only > > where needed. > > Hm, but why? Are there adverse effects if this is included by > <linux/serial_core.h>? Compilation time and general code hygiene. Headers shouldn't include more than needed. And in this case only a single driver (besides core) is actually using the gpio interface. Johan
