Hi Geert,
On Fri, Jun 5, 2020 at 1:52 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Sun, May 3, 2020 at 11:47 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > Add support for iWave RainboW-G21D-Qseven board based on RZ/G1H.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx>
>
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> > @@ -0,0 +1,37 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Device Tree Source for the iWave-RZ/G1H Qseven board
> > + *
> > + * Copyright (C) 2020 Renesas Electronics Corp.
> > + */
> > +
> > +/dts-v1/;
> > +#include "r8a7742-iwg21m.dtsi"
> > +
> > +/ {
> > + model = "iWave Systems RainboW-G21D-Qseven board based on RZ/G1H";
> > + compatible = "iwave,g21d", "iwave,g21m", "renesas,r8a7742";
> > +
> > + aliases {
> > + serial2 = &scifa2;
> > + };
> > +
> > + chosen {
> > + bootargs = "ignore_loglevel root=/dev/mmcblk0p1 rw rootwait";
> > + stdout-path = "serial2:115200n8";
> > + };
> > +};
> > +
> > +&pfc {
> > + scifa2_pins: scifa2 {
> > + groups = "scifa2_data_c";
>
> Upon second look, I think this group is wrong. While labeled SCIFA2 in
> the SOM schematics, these signals seem to be connected to a debugging
> interface.
>
> The real UART2 seems to be present on the camera daughter board. Those
> signals are labeled "SCIFA2" in the camera board schematics, but "SCIF2"
> in the SOM schematics. This is OK, as "scif2_data" and "scifa2_data"
> share the same pins, so you can choose either SCIF2 or SCIFA2 to drive
> them.
>
> If I'm right, please change the group, and move all serial2 descriptions
> to the camera board DTS.
>
I took a closer look at the schematics, SCIFA2 is connected to the
debug interface similarly on G1M where SCIF0 is connected to the debug
interface.
I will send the user guide privately which should clarify the serial
interfaces on the board.
Cheers,
--Prabhakar
> > + function = "scifa2";
> > + };
> > +};
> > +
> > +&scifa2 {
> > + pinctrl-0 = <&scifa2_pins>;
> > + pinctrl-names = "default";
> > +
> > + status = "okay";
> > +};
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
