On Fri, May 15, 2020 at 8:46 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, May 06, 2020 at 03:23:12PM +0800, Claire Chang wrote: > > serial_match_port() uses devt to match devices. However, when serdev > > registers a tty port, devt has never been set. This makes > > device_find_child() always return NULL. > > > > Assign devt in serdev_tty_port_register() to fix this. > > > > Signed-off-by: Claire Chang <tientzu@xxxxxxxxxxxx> > > --- > > drivers/tty/serdev/serdev-ttyport.c | 2 ++ > > 1 file changed, 2 insertions(+) > > So is existing code broken because of this? Or does no one ever call > device_find_child() on this? Who needs/uses this? > > thanks, > > greg k-h I'm not sure. Our use case is to control the wake on bluetooth behavior by the power/wakeup node. `readlink -f /sys/class/bluetooth/hci0` /sys/devices/platform/soc/11003000.serial/serial0/serial0-0/bluetooth/hci0 and we'd like to use `/sys/devices/platform/soc/11003000.serial/serial0/power/wakeup` to decide whether to enable the in-band wakeup on uart host side. Thanks, Claire
