On Thu, May 14, 2020 at 07:04:29PM +0530, Mukesh, Savaliya wrote:
> From: Mukesh Kumar Savaliya <msavaliy@xxxxxxxxxxxxxx>
>
> This change enables earlyconsole support as static driver for geni
> based UART. Kernel space UART console driver will be generic for
> console and other usecases of UART.
>
> Signed-off-by: Mukesh Kumar Savaliya <msavaliy@xxxxxxxxxxxxxx>
> ---
> Removed mb() calls as *_relaxed() should take care.
What about what happened from v1?
ALways keep the full changelog here, otherwise we don't remember what
happened.
> +static void se_io_set_mode_earlycon(void __iomem *base)
> +{
> + unsigned int io_mode;
> +
> + io_mode = readl_relaxed(base+SE_IRQ_EN);
io_mode = readl_relaxed(base + SE_IRQ_EN);
please. Use ' ', there is no need to not do so.
thanks,
greg k-h
