On Fri, Apr 03, 2020 at 9:00: 10PM +0900, Krzysztof Kozlowski wrote: > On Fri, Apr 03, 2020 at 08:15:10PM +0900, Hyunki Koo wrote: > > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > > > This is required for some newer SoCs. > > > > Signed-off-by: Hyunki Koo <hyunki00.koo@xxxxxxxxxxx> > > --- > > v2: > > line 954 : change rd_regl to rd_reg in for backward compatibility. > > I did not see any change around line 954 in v1... so what was it? 954 line is changed like below. V1 : rd_regb --> rd_regl : we thought, this register need to change to V2: rd_regl --> rd_reg : we discuss internally, and I decided not to change to existing devices for backward compatibility. So we changed to rd_reg. > > Rest looks good for me, although you should address Greg's comments. > > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Tested on Odroid > HC1 (Exynos5422): > Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Best regards, > Krzysztof
